Add unit tests for cloud API datasets module#14
Merged
Conversation
The fix from 804dd90 correctly removed @validate_call from listDatasets (and createDataset/listAllDatasets), making org_id optional and resolved from client config. These unit tests verify the fix works and guard against regression. https://claude.ai/code/session_011B2Dj4a62UZAffje5gGero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive unit tests for the
ndi.cloud.api.datasetsmodule, covering the core dataset operations without requiring network access.Key Changes
Added
TestListDatasetsclass with three test cases:listDatasets()resolvesorg_idfrom client config when not explicitly providedorg_idparameter takes precedence over client configValueErroris raised whenorg_idis missing from both parameter and configAdded
TestListAllDatasetsclass:listAllDatasets()functionality without explicitorg_idAdded
TestCreateDatasetclass with two test cases:createDataset()usesorg_idfrom client configValueErroris raised whenorg_idis missingImplemented
_make_client()helper function to create mock CloudClient instances with configurable organization IDsNotable Implementation Details
unittest.mock.MagicMockto avoid network callsorg_idparameter with fallback to client confighttps://claude.ai/code/session_011B2Dj4a62UZAffje5gGero